[RLlib]: Fix FQE Policy call #26671
Merged
[RLlib]: Fix FQE Policy call #26671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rohan138
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
Signed-off-by: rapotdar <[email protected]>
richardliaw
requested changes
Jul 18, 2022
| @@ -162,6 +166,44 @@ def test_ope_in_algo(self): | |||
| print(*list(std_est.items()), sep="\n") | |||
| print("\n\n\n") | |||
|
|
|||
| def test_fqe_model(self): | |||
| # Miscellaneous tests for FQETorchModel | |||
There was a problem hiding this comment.
write a docstring on what this function is testing?
kouroshHakha
approved these changes
Jul 19, 2022
Signed-off-by: rapotdar <[email protected]>
richardliaw
approved these changes
Jul 19, 2022
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
Signed-off-by: Xiaowei Jiang <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Hotfix to make OPE work for both PolicyV2 and DQNTorchPolicy (Policyv1)
Checks
scripts/format.shto lint the changes in this PR.